Skip to content

Conversation

@yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Aug 16, 2024

What does the PR do?

Tests histogram metric in custom_metrics.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • test

Related PRs:

triton-inference-server/vllm_backend#56
triton-inference-server/python_backend#374
triton-inference-server/core#386

Where should the reviewer start?

n/a

Test plan:

n/a

  • CI Pipeline ID:
    17487728

Caveats:

n/a

Background

Customer requested histogram metrics from vLLM.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

n/a

@yinggeh yinggeh self-assigned this Aug 16, 2024
rmccorm4
rmccorm4 previously approved these changes Aug 16, 2024
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for cherry-pick purposes, but some comments for improving the tests later on.

…hub.com:triton-inference-server/server into yinggeh-DLIS-7113-support-histogram-metric-type
rmccorm4
rmccorm4 previously approved these changes Aug 16, 2024
@rmccorm4
Copy link
Contributor

Please trigger a pipeline encapsulating all the latest changes so can feel confident in the CI impact when looking at the cherry-picks

@yinggeh
Copy link
Contributor Author

yinggeh commented Aug 16, 2024

Merged #7525 to the wrong branch. Need re-approval to merge to main.

@yinggeh yinggeh changed the title test: Test histogram metric test: Add python backend tests for the new histogram metric Aug 17, 2024
@yinggeh yinggeh merged commit 62184db into main Aug 17, 2024
@yinggeh yinggeh deleted the yinggeh-DLIS-7113-support-histogram-metric-type branch August 17, 2024 00:12
@yinggeh yinggeh restored the yinggeh-DLIS-7113-support-histogram-metric-type branch August 17, 2024 00:12
@yinggeh yinggeh added the PR: test Adding missing tests or correcting existing test label Aug 17, 2024
mc-nv added a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: test Adding missing tests or correcting existing test

Development

Successfully merging this pull request may close these issues.

3 participants